external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address review

all-test-improvements
Jelte Fennema 2022-03-01 13:55:37 +01:00
parent 3bc953404e
commit d5397b3a1f
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py
View File

@ -55,7 +55,6 @@ def run_for_config(config, lock, sql_schedule_name):
if config.user == cfg.REGULAR_USER_NAME: if config.user == cfg.REGULAR_USER_NAME:
common.create_role( common.create_role(
config.bindir, config.bindir,
config.coordinator_port(),
config.node_name_to_ports.values(), config.node_name_to_ports.values(),
config.user, config.user,
) )

4
src/test/regress/citus_tests/common.py
View File

@ -62,7 +62,7 @@ def add_settings(abs_data_path, settings):
conf_file.write(setting) conf_file.write(setting)
def create_role(pg_path, coordinator_port, node_ports, user_name): def create_role(pg_path, node_ports, user_name):
def create(port): def create(port):
command = "SELECT worker_create_or_alter_role('{}', 'CREATE ROLE {} WITH LOGIN CREATEROLE CREATEDB;', NULL)".format( command = "SELECT worker_create_or_alter_role('{}', 'CREATE ROLE {} WITH LOGIN CREATEROLE CREATEDB;', NULL)".format(
user_name, user_name user_name, user_name
@ -106,7 +106,7 @@ def start_databases(pg_path, rel_data_path, node_name_to_ports, logfile_prefix,
parallel_run(start, node_name_to_ports.keys()) parallel_run(start, node_name_to_ports.keys())
# We don't want parallel shutdown, here because that will fail when it's # We don't want parallel shutdown here because that will fail when it's
# tried in this atexit call with an error like: # tried in this atexit call with an error like:
# cannot schedule new futures after interpreter shutdown # cannot schedule new futures after interpreter shutdown
atexit.register( atexit.register(