Update todos

velioglu/wo_seq_test_1
Burak Velioglu 2021-12-28 11:17:43 +03:00
parent cfe3f97faf
commit d912cd9a9b
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
2 changed files with 2 additions and 4 deletions

View File

@ -59,8 +59,6 @@ EnsureDependenciesExistOnAllNodes(const ObjectAddress *target)
/* collect all dependencies in creation order and get their ddl commands */ /* collect all dependencies in creation order and get their ddl commands */
List *dependencies = GetDependenciesForObject(target); List *dependencies = GetDependenciesForObject(target);
/* TODO: Might add check for PG (not Citus) tables */
ObjectAddress *dependency = NULL; ObjectAddress *dependency = NULL;
foreach_ptr(dependency, dependencies) foreach_ptr(dependency, dependencies)
{ {
@ -257,7 +255,7 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency)
tableDDLCommand)); tableDDLCommand));
} }
/* TODO: May need to move sequence dependencies to ActiveNode directly */ /* TODO: May need to move sequence dependencies to ActivateNode directly */
List *sequenceDependencyCommandList = SequenceDependencyCommandList( List *sequenceDependencyCommandList = SequenceDependencyCommandList(
dependency->objectId); dependency->objectId);
commandList = list_concat(commandList, sequenceDependencyCommandList); commandList = list_concat(commandList, sequenceDependencyCommandList);

View File

@ -677,7 +677,7 @@ SupportedDependencyByCitus(const ObjectAddress *address)
*/ */
if (relKind == RELKIND_COMPOSITE_TYPE || if (relKind == RELKIND_COMPOSITE_TYPE ||
relKind == RELKIND_RELATION || relKind == RELKIND_RELATION ||
relKind == RELKIND_PARTITIONED_TABLE || /* TODO: Should check for normal tables? */ relKind == RELKIND_PARTITIONED_TABLE ||
relKind == RELKIND_SEQUENCE) relKind == RELKIND_SEQUENCE)
{ {
return true; return true;