external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Increment command counter in FinishModifyRelation instead 

Seems that we always increment the command counter right after
finishing metadata table modification.

For this reason, it makes sense to call CommandCounterIncrement
within FinishModifyRelation.
pull/5154/head
Onur Tirtir 2021-07-29 16:13:18 +03:00
parent 0b4ed075b5
commit db0e4ce889
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/columnar/columnar_metadata.c
View File

@ -484,8 +484,6 @@ SaveStripeSkipList(RelFileNode relfilenode, uint64 stripe, StripeSkipList *chunk
FinishModifyRelation(modifyState);
table_close(columnarChunk, RowExclusiveLock);
CommandCounterIncrement();
}
@ -522,8 +520,6 @@ SaveChunkGroups(RelFileNode relfilenode, uint64 stripe,
FinishModifyRelation(modifyState);
table_close(columnarChunkGroup, NoLock);
CommandCounterIncrement();
}
@ -887,8 +883,6 @@ InsertStripeMetadataRow(uint64 storageId, StripeMetadata *stripe)
FinishModifyRelation(modifyState);
CommandCounterIncrement();
table_close(columnarStripes, RowExclusiveLock);
}
@ -1206,6 +1200,8 @@ FinishModifyRelation(ModifyState *state)
ExecCleanUpTriggerState(state->estate);
ExecResetTupleTable(state->estate->es_tupleTable, false);
FreeExecutorState(state->estate);
CommandCounterIncrement();
}