Commit Graph

6782 Commits (4087d1941db7e4356af8e1165bfa3eef504e8d04)

Author SHA1 Message Date
gindibay 4087d1941d Fixes review comments 2023-10-13 00:12:38 +03:00
Gürkan İndibay e716f58955
Merge branch 'main' into create_alter_database 2023-10-12 09:53:08 +03:00
Gokhan Gulbiz e0b0cdbb87
CircleCI to GHA migration (#7154)
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
2023-10-10 16:58:50 +03:00
Gürkan İndibay f7f768168b
Merge branch 'main' into create_alter_database 2023-10-10 11:02:40 +03:00
Emel Şimşek e9035f6d32
Send keepalive messages in split decoder periodically to avoid wal receiver timeouts during large shard splits. (#7229)
DESCRIPTION: Send keepalive messages during the logical replication
phase of large shard splits to avoid timeouts.

During the logical replication part of the shard split process, split
decoder filters out the wal records produced by the initial copy. If the
number of wal records is big, then split decoder ends up processing for
a long time before sending out any wal records through pgoutput. Hence
the wal receiver may time out and restarts repeatedly causing our split
driver code catch up logic to fail.

Notes: 

1. If the wal_receiver_timeout is set to a very small number e.g. 600ms,
it may time out before receiving the keepalives. My tests show that this
code works best when the` wal_receiver_timeout `is set to 1minute, which
is the default value.

2. Once a logical replication worker time outs, a new one gets launched.
The new logical replication worker sets the pg_stat_subscription columns
to initial values. E.g. the latest_end_lsn is set to 0. Our driver logic
in `WaitForGroupedLogicalRepTargetsToCatchUp` can not handle LSN value
to go back. This is the main reason for it to get stuck in the infinite
loop.
2023-10-09 22:33:08 +03:00
gindibay 723c2b154f Fixes indentation 2023-10-09 20:27:50 +03:00
gindibay 78f8ae22c4 Clarifies the code 2023-10-09 20:24:34 +03:00
gindibay 1a26316cef Fixes indentation 2023-10-09 20:03:07 +03:00
gindibay be9f660fad Fixes PostprocessCreateDatabaseStmt comment 2023-10-09 20:01:29 +03:00
gindibay b04c52abb9 Fixes compile error 2023-10-09 19:44:36 +03:00
gindibay 5dd6ed6935 Fixes review comments 2023-10-09 19:42:17 +03:00
gindibay d573910f2a Fixes the comment 2023-10-09 18:10:28 +03:00
Nils Dijk 76fdfa3c0f
Add devcontainer for development purposes (#7102)
This change adds a devcontainer configuration to the Citus project. This
devcontainer allows for quick generation of isolated development
environments, either local on the machine of a developer or in a cloud,
like github codepaces.

The devcontainer is updated automatically by github actions when its
configuration changes.

For more detailed instructions on how to quickstart the development in a
container see CONTRIBUTING.md
2023-10-09 15:37:21 +02:00
gindibay 3547eeeb6f Adds PG_VERSION_15 constant 2023-10-09 16:05:07 +03:00
gindibay 4b4aae2d4a Fixes compile error 2023-10-09 16:00:18 +03:00
gindibay 69ccf7dd97 Fixes indent 2023-10-09 15:57:34 +03:00
gindibay 45103629dc Fixes compile error for PG 14 2023-10-09 15:56:05 +03:00
gindibay 7022344870 Adds missing types 2023-10-09 15:14:13 +03:00
Nils Dijk 6d8725efb0
Fix leaking of memory and memory contexts in Foreign Constraint Graphs (#7236)
DESCRIPTION: Fix leaking of memory and memory contexts in Foreign
Constraint Graphs

Previously, every time we (re)created the Foreign Constraint
Relationship Graph, we created a new Memory Context while loosing a
reference to the previous context. This old context could still have
left over memory in there causing a memory leak.

With this patch we statically have one memory context that we lazily
initialize the first time we create our foreign constraint relationship
graph. On every subsequent creation, beside destroying our previous
hashmap we also reset our memory context to remove any left over
references.
2023-10-09 13:05:51 +02:00
gindibay b99674dcf9 Removes T_Boolean since it breaks pg14 compile 2023-10-09 13:46:54 +03:00
gindibay 2b04873159 Fixes indentation 2023-10-09 13:28:23 +03:00
gindibay 6846b7fbc7 Refactors the code to make more managable 2023-10-09 13:27:12 +03:00
Onur Tirtir 858d99be33
Take improvement_threshold into the account in citus_add_rebalance_strategy() (#7247)
DESCRIPTION: Makes sure to take improvement_threshold into the account
in `citus_add_rebalance_strategy()`.

Fixes https://github.com/citusdata/citus/issues/7188.
2023-10-09 13:13:08 +03:00
gindibay 93ccbf74d8 Fixes pg15 output 2023-10-06 19:14:21 +03:00
gindibay 8d59e891f0 Fixes icu locale 2023-10-06 18:58:52 +03:00
gindibay c4f8acb0d9 Updates test results 2023-10-06 18:33:10 +03:00
gindibay 35c04c5d48 Fixes collate and ctype 2023-10-06 18:14:00 +03:00
gindibay 92c1b2bc2c Removes iculocale 2023-10-06 18:02:43 +03:00
gindibay 48359e5b3b Fixes Locale 2023-10-06 17:50:10 +03:00
gindibay a19b8216a2 Fixes locale 2023-10-06 17:03:57 +03:00
gindibay d218c31893 Fixes UTF error 2023-10-06 17:01:27 +03:00
gindibay 8251a22bee Fixes pg15 tests 2023-10-06 16:41:07 +03:00
gindibay fc67b6748d Fixes encodings for pg16 2023-10-06 16:10:47 +03:00
gindibay 2162c89efd Revert "Removes pg15 changes to test unusal failures"
This reverts commit 85963e9cb5.
2023-10-06 15:47:42 +03:00
gindibay 791fe0db48 Adds tablespace to test tablespace statement 2023-10-06 15:45:05 +03:00
gindibay 4dff8f3c67 Fixes tests 2023-10-06 15:24:23 +03:00
gindibay 6d429521b6 Fixes indentation 2023-10-06 15:22:15 +03:00
gindibay 8ded5bc256 Fixes pg_dist_object delete problem 2023-10-06 15:18:16 +03:00
Önder Kalacı 7d6c401dd3
Update technical readme (#7248)
Fix a wrong query, reported by @naisila
2023-10-06 13:37:37 +03:00
gindibay 8f08074720 Adds OID to see the error cause 2023-10-05 22:30:06 +03:00
gindibay 76f1d242c9 Changes test order 2023-10-05 22:14:12 +03:00
gindibay eaf26ee601 Changes schedule location 2023-10-05 21:48:28 +03:00
gindibay e75c820ccb Rollbacks last test 2023-10-05 21:34:14 +03:00
gindibay 0c1de3484e Rollbacks pg_regress_multi 2023-10-05 20:49:19 +03:00
gindibay fd9a8f3192 Fixes pg15 file 2023-10-05 20:36:47 +03:00
gindibay 1ab31646d8 Tests error cause 2023-10-05 20:35:22 +03:00
gindibay 85963e9cb5 Removes pg15 changes to test unusal failures 2023-10-05 19:44:57 +03:00
gindibay 04c46b4099 Fixes tablespace results 2023-10-05 17:51:01 +03:00
gindibay 7ccd8c8390 Fixes tablespace error 2023-10-05 17:48:36 +03:00
gindibay 8bce0386d7 Removes unnecessary fileds from selects 2023-10-05 17:27:07 +03:00