Commit Graph

2207 Commits (d9d1dfbfb503fe0cbb505e87ab0521cb3a2e61b5)

Author SHA1 Message Date
Onder Kalaci d9d1dfbfb5 respect the regression tests for recursively plan inner parts of recurring tuple joins 2018-11-28 19:34:03 +03:00
Onder Kalaci e2f99a04bc Recursively plan inner parts of recurring tuple joins
With this commit, we're enabling recursive planning for the
queries that used to fail due to recurring tuples.

We're simply returning the inner relations/subqueries to the caller
of the error check, which is then able to recursively plan them.
2018-11-28 15:08:39 +03:00
Onder Kalaci 3bd613ca8c Add 9.6 test output files
This commit should be reverted. RequiredAttrNumbersForRelation() should return
only the necessary columns.
2018-11-27 16:05:12 +03:00
Onder Kalaci 00b9338294 Pushdown only necessary projections in the recursive relation planning
With this commit, we only pull&push the necessary columns. In this
context, necessary columns means that the columns that are required
for the query to be executed when the relation is wrapped into a
subquery.

We could potentially optimize things further:

(a) If a column only appears as a qual filter, we don't need to
    pull it to the coordinator
(b) We currently pull unnecessary columns as NULL. However, we
    could potentially adjust remaining of the query tree and do
    not add columns of the relation to the target entry.
2018-11-27 13:07:32 +03:00
Onder Kalaci 6b2a412c12 Add tests for filter pushdown 2018-11-27 13:07:32 +03:00
Onder Kalaci 3ac4c1c3a2 Pushdown filters on recursive relation planning
PostgreSQL already keeps track of the restrictions that are on the relation.
With this commit, Citus uses that information and pushes down the filters
to the subquery that is recursively planned for the table that is in
considiration.
2018-11-27 13:07:32 +03:00
Onder Kalaci 94ea93c0ae Basic implementation of recursive planning of non-colocated relation joins 2018-11-27 13:07:32 +03:00
Marco Slot 6fd5c73444
Merge pull request #2492 from citusdata/udf_cleanup
Clean up UDFs and revoke unnecessary permissions
2018-11-26 14:21:34 +01:00
Marco Slot 1ec5b6c890 Remove old worker_hash_partition_table API 2018-11-26 14:40:37 +01:00
Marco Slot 5a63deab2e Clean up UDFs and remove unnecessary permissions 2018-11-26 14:40:37 +01:00
hanefi 27930aa462
Merge pull request #2488 from citusdata/validate_constraint
Validate Constraint Support
2018-11-26 15:20:01 +03:00
Hanefi Onaldi 448b241ab4 validate query isolation tests 2018-11-26 14:04:51 +03:00
Hanefi Onaldi 4edb193f25 make the tests parallelizeable
helper view table_fkeys_in_workers now allows filtering by schema so that a test case can print out foreign keys in its schema only
2018-11-26 14:04:51 +03:00
Hanefi Onaldi b3d897039a constraint validation regression tests 2018-11-26 14:04:51 +03:00
Hanefi Onaldi 7db6991dc0 propagate validate queries to workers 2018-11-26 14:04:51 +03:00
Marco Slot 2afbb89673
Merge pull request #2490 from citusdata/fix_tt_protocol
Check ownership in task-tracker protocol functions
2018-11-26 11:45:50 +01:00
Marco Slot e8e956aa9f Require superuser when using non-existent job schema in worker_merge_files_into_table 2018-11-24 02:57:16 +01:00
Marco Slot 711eef611f
Merge pull request #2489 from citusdata/task_tracker_suffix
Add user ID suffix to intermediate files in task-tracker
2018-11-23 14:17:37 +01:00
Marco Slot c4ad899dd8 Check schema ownership in worker_merge_* functions 2018-11-23 11:05:09 +01:00
Marco Slot e9a7295ead Add multi-user tests for task-tracker protocol functions 2018-11-23 11:05:09 +01:00
Marco Slot 8e93fe5870 Check schema owner in task_tracker_assign_task 2018-11-23 11:05:09 +01:00
Marco Slot ec957a833a Check permission in task_tracker_task_status 2018-11-23 11:04:58 +01:00
Marco Slot 4245032849 Add user ID suffixes to filenames in check-worker tests 2018-11-23 08:36:12 +01:00
Marco Slot 6aa5592e52 Add user ID suffix to intermediate files in re-partition jobs 2018-11-23 08:36:11 +01:00
Marco Slot f608739b4f
Merge pull request #2487 from citusdata/task_result_udf
Execute SQL tasks using worker_execute_sql_task UDF when using task-tracker
2018-11-22 18:10:04 +01:00
Marco Slot a59bf31c76 Use worker_execute_sql_task UDF in task-tracker executor 2018-11-22 18:15:33 +01:00
Marco Slot 30bad7e66f Add worker_execute_sql_task UDF 2018-11-22 18:15:33 +01:00
Marco Slot e3521ce320 Test current user in task-tracker queries 2018-11-22 18:15:33 +01:00
Marco Slot caf402d506 COPY to a task file no longer switches to superuser 2018-11-22 18:15:33 +01:00
Marco Slot 9ff6f1c552
Merge pull request #2483 from citusdata/fix_udf_permissions
Fix permissions checks in lesser-known UDFs
2018-11-20 14:51:57 +01:00
Marco Slot e17025e1d4 Check table ownership in mark_tables_colocated 2018-11-18 00:11:38 +01:00
Marco Slot 18acd00553 Check permissions in lock_relation_if_exists 2018-11-18 00:11:38 +01:00
Marco Slot aab9f623eb Check table ownership in upgrade_to_reference_table 2018-11-16 23:27:34 +01:00
Önder Kalacı fc9f981525
Merge pull request #2475 from citusdata/fix_some_user_permission_bugx
Fix permissions checks in UDFs called from the drop table trigger
2018-11-15 16:46:38 +01:00
Onder Kalaci 052ba21b19 Make sure to prevent unauthorized users to drop sequences in Citus MX 2018-11-15 18:08:04 +03:00
Onder Kalaci 7f0a57a153 Make sure to prevent unauthorized users to drop tables in Citus MX 2018-11-15 18:07:03 +03:00
Nils Dijk f9520be011
Round robin queries to reference tables with task_assignment_policy set to `round-robin` (#2472)
Description: Support round-robin `task_assignment_policy` for queries to reference tables.

This PR allows users to query multiple placements of shards in a round robin fashion. When `citus.task_assignment_policy` is set to `'round-robin'` the planner will use a round robin scheduling feature when multiple shard placements are available.

The primary use-case is spreading the load of reference table queries to all the nodes in the cluster instead of hammering only the first placement of the reference table. Since reference tables share the same path for selecting the shards with single shard queries that have multiple placements (`citus.shard_replication_factor > 1`) this setting also allows users to spread the query load on these shards.

For modifying queries we do not apply a round-robin strategy. This would be negated by an extra reordering step in the executor for such queries where a `first-replica` strategy is enforced.
2018-11-15 15:11:15 +01:00
Murat Tuncer 5f821e6f64
Merge pull request #2468 from citusdata/update_who_uses_citus
Expand who is using Citus section in readme
2018-11-15 15:11:02 +03:00
Murat Tuncer 58cb473958 Expand who is using Citus section in readme
- add new users (Pex, Algolia, Copper) to who is using Citus part
- add a reference to more use cases in Citus web page
2018-11-15 14:42:54 +03:00
Marco Slot 586f398b47
Merge pull request #2473 from citusdata/node_udf_permissions
Use function permissions to guard node metadata functions
2018-11-15 12:23:53 +01:00
Marco Slot 2de8ef29c3 Revoke function permissions for node metadata functions 2018-11-15 06:25:07 +01:00
Burak Velioglu ef24895add
Merge pull request #2478 from citusdata/master-8.0.0-14112018
Add changelog entry for 7.5.2
2018-11-14 23:31:19 +03:00
velioglu 9b5e4942a0 Add changelog entry for 7.5.2 2018-11-14 21:26:29 +03:00
Nils Dijk bafec7ea48
Merge pull request #2469 from citusdata/refactor/commands-extract
Refactor the UtilityProcess function into its own module
2018-11-14 15:08:06 +01:00
Marco Slot f383e4f307
Description: Refactor code that handles DDL commands from one file into a module
The file handling the utility functions (DDL) for citus organically grew over time and became unreasonably large. This refactor takes that file and refactored the functionality into separate files per command. Initially modeled after the directory and file layout that can be found in postgres.

Although the size of the change is quite big there are barely any code changes. Only one two functions have been added for readability purposes:

- PostProcessIndexStmt which is extracted from PostProcessUtility
- PostProcessAlterTableStmt which is extracted from multi_ProcessUtility

A README.md has been added to `src/backend/distributed/commands` describing the contents of the module and every file in the module.
We need more documentation around the overloading of the COPY command, for now the boilerplate has been added for people with better knowledge to fill out.
2018-11-14 13:36:27 +01:00
Burak Yücesoy ce463e9812
Merge pull request #2467 from citusdata/fix-crashes-on-ooms
Fix crashes caused by stack size increase under high memory load
2018-11-14 10:49:06 +03:00
Burak Yucesoy f8e0d37ba1 Fix crashes caused by stack size increase under high memory load
Each PostgreSQL backend starts with a predefined amount of stack and this stack
size can be increased if there is a need. However, stack size increase during
high memory load may cause unexpected crashes, because if there is not enough
memory for stack size increase, there is nothing to do for process apart from
crashing. An interesting thing is; the process would get OOM error instead of
crash, if the process had an explicit memory request (with palloc) for example.
However, in the case of stack size increase, there is no system call to get OOM
error, so the process simply crashes.

With this change, we are increasing the stack size explicitly by requesting extra
memory from the stack, so that, even if there is not memory, we can at least get
an OOM instead of a crash.
2018-11-14 01:27:53 +03:00
Nils Dijk 2cc803afe0
Merge pull request #2474 from citusdata/fix/min-client-message-fatal
Fix failures of tests on recent postgres builds
2018-11-13 17:40:21 +01:00
Nils Dijk 97da44558b
Description: Fix failures of tests on recent postgres builds
In recent postgres builds you cannot set client_min_messages to
values higher then ERROR, if will silently set it to ERROR if so.

During some tests we would set it to fatal to hide random values
(eg. pid's of processes) from the test output. This patch will use
different tactics for hiding these values.
2018-11-13 16:53:05 +01:00
Murat Tuncer 22e516a4c4
Merge pull request #2471 from citusdata/update_hll_topn_versions
Update topn and hll versions used in travis
2018-11-07 17:27:12 +03:00