* Temporary disable all workflows except one
* Try ubuntu 20.04
* Remove redundant working dir config
* Fix
* Try perform some operations from default user
* Try fix
* Revert "Try fix"
This reverts commit 3ed843c7462f69d7ad74ba6f60c93544e1ea549c.
* Revert "Try perform some operations from default user"
This reverts commit 206046714d888b518bce2f83f567176978a73af9.
* Switch back to ubuntu 22.04
* Add debug
* Try fix
* Hit CI
* More debug
* Revert "Remove redundant working dir config"
This reverts commit 3d1ade8948.
* Revert "Fix"
This reverts commit 05dbeed894.
* Try fix
* Revert some changes
* Revert "Temporary disable all workflows except one"
This reverts commit 93b35036fb.
* Fix pgdg workflows
* Fix ppg workflows
* Fix MAX_BUCKETS_MEM overflow
* Fix MAX_QUERY_BUF overflow
* Fix int overflow in IsBucketValid function
* Add missing newline
* Remove test for max value of pgsm_query_shared_buffer parameter
* Tune tests
* Cleanup
* Use int64 type instead of long long
A potential lock contention could've been caused when an OOM warning
was being emitted by the pgsm_store function. This could lead the
pg_store_error function calling pgsm_store function and thereby trying
to acquire and exclusive lock when a shared was already by the same
process. This warning is now guarded by protection block.
PG-624: pg_stat_monitor: Possible server crash when running pgbench
with pg_stat_monitor loaded
It appears that this issue was being caused by improper handling of
dynamic number of buckets. This commit resolves the issue.
Also, as part of a larger cleanup, memory context has been moved to
local space from shared storage. Also, some unwanted
and no-longer-needed variables are removed.
Co-authored-by: Muhammad Usama <muhammad.usama@percona.com>
The return value for snprintf was incorrectly being recorded as plan
length. That's been resolved.
As part of this fix, we've also elminated the possibility of a potential
memory leak when plan text was being saved.
Co-authored-by: Hamid Akhtar <hamid.akhtar@percona.com>
Co-authored-by: Muhammad Usama <muhammad.usama@percona.com>
* PG-607: Allow histogram to track queries in sub-ms time brackets
Updated the GUC configuration and the relevant histogram functionality
to track queries in lower cardinality than ms. This is done by saving
the GUC values for histogram min and max values in real (double) type.
All test cases except for the 030 tap test are passing. The test case
needs an update.
* Fixing regression issues for v12 and below because of histogram changes.
* PG-606: New GUC required for enabling/disabling of pgsm_query_id calculation
Adds a new GUC pg_stat_monitor.pgsm_enable_pgsm_query_id to enable/disable
pgsm query id calculation. Apart from that patch also refactors the GUC-related
code to match PostgreSQL conventions.
Moreover, the commit also changes the pgsm_enable_overflow GUC to boolean
instead of enum.
Saving the client IP address once per the lifetime of a backend. This avoid
the expensive operation multiple times, and hence improving performance
significantly.
Performance related changes where some calculations are moved out
of the spinlock in the pgsm_update_entry function. This should
improve the performance a bit.
Also, moved the histogram calculation function to init. The update
function now only searches an array rather than recalculatiing the
histogram bucket timings.
Updated conditional statement to update parent query only when
required.
Artem Gavrilov
Artem Gavrilov
Muhammad Aqeel
Hamid Akhtar
Naeem Akhter
Muhammad Usama
Zsolt Parragi
EvgeniyPatlan
Mikail
Naeem Akhter
Ibrar Ahmed