61662cc58f
PG-1621: fix cmd_type mostly showing 0 values ( #538 )
...
This was actually caused by two bugs internally:
* cmd_type was only set in some codepaths, other parts of the code
never set a value. Depending on which query / how was executed,
it was possibly never changed (after a reset to 0)
* the update first set the cmd_type, then reset all counters. As
the cmd_type is stored within the counters for some reason, this
reset its value to 0 in most execution paths, even if it was corretly
set before.
And according to this the fix is simple:
* cmd_type is now set in all codepaths except for failing queries,
as we only have the error string in this case, without the type.
* in the update logic, we again overwrite cmd_type with the proper
value after a reset
2025-06-17 14:52:28 +01:00
f7dc7fb5fe
Bump github/codeql-action from 3.28.19 to 3.29.0 ( #541 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.19 to 3.29.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fca7ace96b...ce28f5bb42
2025-06-17 14:25:52 +02:00
38f13e893f
Bump github/codeql-action from 3.28.18 to 3.28.19 ( #540 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.18 to 3.28.19.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ff0a06e83c...fca7ace96b
2025-06-11 14:09:21 +02:00
9d2f2cd8cc
Bump ossf/scorecard-action from 2.4.1 to 2.4.2 ( #537 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](f49aabe0b5...05b42c6244
2025-06-06 13:46:18 +02:00
d0237f8d83
Bump github/codeql-action from 3.28.17 to 3.28.18 ( #534 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.17 to 3.28.18.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](60168efe1c...ff0a06e83c
2025-05-21 12:01:55 +02:00
d116dd47fe
Bump codecov/codecov-action from 5.4.2 to 5.4.3 ( #535 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.4.2 to 5.4.3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](ad3126e916...18283e04ce
2025-05-21 12:01:33 +02:00
9c72c2e73d
Bump github/codeql-action from 3.28.16 to 3.28.17 ( #533 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.16 to 3.28.17.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](28deaeda66...60168efe1c
2025-05-05 23:58:23 +02:00
76424b6c64
Bump github/codeql-action from 3.28.14 to 3.28.16 ( #532 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.14 to 3.28.16.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fc7e4a0fa0...28deaeda66
2025-04-28 20:44:08 +02:00
f76b1860e3
Bump codecov/codecov-action from 5.4.0 to 5.4.2 ( #531 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.4.0 to 5.4.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](0565863a31...ad3126e916
2025-04-23 19:02:17 +02:00
a7edd766e3
Update CODEOWNERS ( #529 )
2025-04-16 15:44:18 +02:00
24c1c59416
PG-1370 PGSM 2.1.1 release ( #514 )
...
PG-1370 Bump PGSM version up to 2.1.1
2025-04-09 18:57:44 +02:00
b860effd97
Bump github/codeql-action from 3.28.13 to 3.28.14 ( #528 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.13 to 3.28.14.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](1b549b9259...fc7e4a0fa0
2025-04-08 10:22:49 +02:00
64b08e422c
Bump github/codeql-action from 3.28.11 to 3.28.13 ( #525 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.11 to 3.28.13.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](6bb031afdd...1b549b9259
2025-04-02 18:22:48 +02:00
acd559842f
Bump actions/upload-artifact from 4.6.1 to 4.6.2 ( #526 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.1 to 4.6.2.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](4cec3d8aa0...ea165f8d65
2025-04-02 18:22:24 +02:00
8bbb49e409
Adds date timestamp to keep packages in different directories. ( #527 )
2025-03-27 16:31:25 +05:00
7bddd5a033
Bump github/codeql-action from 3.28.10 to 3.28.11 ( #524 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.10 to 3.28.11.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b56ba49b26...6bb031afdd
2025-03-11 14:24:19 +02:00
5312f6f8a7
Bump actions/upload-artifact from 4.6.0 to 4.6.1 ( #523 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](65c4c4a1dd...4cec3d8aa0
2025-03-05 12:26:33 +02:00
c305b8a086
Bump github/codeql-action from 3.28.9 to 3.28.10 ( #522 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9e8d0789d4...b56ba49b26
2025-03-05 12:25:58 +02:00
8dcf24a879
Bump ossf/scorecard-action from 2.4.0 to 2.4.1 ( #521 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](62b2cac7ed...f49aabe0b5
2025-03-05 12:25:36 +02:00
32b1beb6ff
Bump codecov/codecov-action from 5.3.1 to 5.4.0 ( #520 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](13ce06bfc6...0565863a31
2025-03-05 12:25:14 +02:00
9333608c3a
PG-1349 Remove call to LWLockRelease() in PG_CATCH()
...
It is not safe to release an LWLock in a catch section without
incrementing InterruptHoldoffCount so let's isntead simply not release
the lock here.
2025-02-20 17:30:24 +01:00
4ebb3d1f36
PG-1349 Prevent LWLock deadlocks from happening
...
Instead of trying to fix every case where we could throw an error and
handling that properly we just make sure to disable the error capture
of the hook while our backend holds the lock.
We keep the check for IsSystemOOM() in the hook even though that might
not be relevant anymore because if we are in OOM it is not like there
would be any point to log the error anyway.
This is done via a global variable, similar to the
__pgsm_do_not_capture_error variable that we are replacing, which we
also use in one place to disable recursive calls to the log hook
where we do not hold the lock.
A potential future improvement would be to make this variable a counter,
or have two separate globals, so that we could guard against recursive
calls to the hook running us out of stack and not just prevent the
deadlocks.
2025-02-20 11:38:37 +01:00
fd43b75153
Revert "PG-156: replace query placeholders with actual arguments for… ( #517 )
...
Revert "PG -156: replace query placeholders with actual arguments for prepared statements (#481 )"
This reverts commit c921d483a8
2025-02-17 19:13:15 +02:00
c949d21656
Add OSSF best practices badge ( #507 )
2025-02-14 14:34:31 +02:00
fbdff8b444
Bump apache/skywalking-eyes from 0.6.0 to 0.7.0 ( #512 )
...
Bumps [apache/skywalking-eyes](https://github.com/apache/skywalking-eyes ) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases )
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md )
- [Commits](cd7b195c51...5c5b974209
2025-02-11 11:35:44 +02:00
e099628e18
Bump github/codeql-action from 3.28.8 to 3.28.9 ( #513 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.8 to 3.28.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](dd746615b3...9e8d0789d4
2025-02-11 11:35:16 +02:00
d2b2eafc85
Bump github/codeql-action from 3.28.5 to 3.28.8 ( #511 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.5 to 3.28.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f6091c0113...dd746615b3
2025-02-04 14:30:59 +02:00
ba8d7bd83b
Bump codecov/codecov-action from 5.1.2 to 5.3.1 ( #509 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.1.2 to 5.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](1e68e06f1d...13ce06bfc6
2025-01-28 16:04:20 +02:00
b47ae95fa8
Bump github/codeql-action from 3.28.1 to 3.28.5 ( #510 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.1 to 3.28.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b6a472f63d...f6091c0113
2025-01-28 16:03:56 +02:00
980116acea
Add issue assingees ( #508 )
2025-01-24 12:01:44 -03:00
ef9518c98e
Bump github/codeql-action from 3.28.0 to 3.28.1 ( #504 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.0 to 3.28.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](48ab28a6f5...b6a472f63d
2025-01-14 14:59:26 +02:00
2769e6dcb2
Bump actions/upload-artifact from 4.5.0 to 4.6.0 ( #505 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](6f51ac03b9...65c4c4a1dd
2025-01-14 14:59:01 +02:00
d0b67ef32a
Bump github/codeql-action from 3.27.9 to 3.28.0 ( #503 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.9 to 3.28.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](df409f7d92...48ab28a6f5
2024-12-23 19:38:41 +02:00
d008bbbfa7
Bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #502 )
...
* Bump actions/upload-artifact from 4.4.3 to 4.5.0
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.4.3...6f51ac03b9356f520e9adb1b1b7802705f340c2b )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update .github/workflows/scorecard.yml
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
2024-12-23 19:38:15 +02:00
971c62025e
Bump codecov/codecov-action from 5.1.1 to 5.1.2 ( #501 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](7f8b4b4bde...1e68e06f1d
2024-12-23 19:36:56 +02:00
8ed7f1dbb7
Bump github/codeql-action from 3.27.6 to 3.27.9 ( #499 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.6 to 3.27.9.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](aa57810251...df409f7d92
2024-12-16 19:55:54 +02:00
2a5a2f07c4
Bump github/codeql-action from 3.27.5 to 3.27.6 ( #498 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.5 to 3.27.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f09c1c0a94...aa57810251
2024-12-11 14:41:17 +02:00
7d57e2476f
Bump codecov/codecov-action from 5.0.7 to 5.1.1 ( #497 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.0.7 to 5.1.1.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](015f24e681...7f8b4b4bde
2024-12-11 14:40:51 +02:00
6c7512afa5
Bump codecov/codecov-action from 5.0.2 to 5.0.7 ( #496 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.0.2 to 5.0.7.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](5c47607acb...015f24e681
2024-11-25 21:21:02 +02:00
ee7f6d071f
Bump github/codeql-action from 3.27.4 to 3.27.5 ( #495 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.4 to 3.27.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](ea9e4e3799...f09c1c0a94
2024-11-25 21:20:38 +02:00
7f1344e12d
Fixes llvm-devel package installation issue. ( #494 )
2024-11-22 12:27:18 +05:00
85f0401b96
Create pull_request_template.md ( #489 )
2024-11-19 09:31:37 +01:00
df65136090
Bump codecov/codecov-action from 4.6.0 to 5.0.2 ( #491 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.6.0 to 5.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](b9fd7d16f6...5c47607acb
2024-11-18 22:21:04 +02:00
534790f39b
Bump ossf/scorecard-action from 2.3.1 to 2.4.0 ( #492 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.1 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](0864cf1902...62b2cac7ed
2024-11-18 22:20:38 +02:00
646f01420f
Bump github/codeql-action from 3.27.3 to 3.27.4 ( #493 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.3 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](396bb3e453...ea9e4e3799
2024-11-18 22:20:11 +02:00
c63e172100
Bump actions/checkout from 4.1.1 to 4.2.2 ( #490 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-18 22:19:34 +02:00
091b5866d4
[StepSecurity] ci: Harden GitHub Actions ( #488 )
...
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
2024-11-14 15:19:16 +02:00
186c2e4795
Add OSSF Scorecard ( #487 )
...
* Create scorecard.yml
* Add OSSF scorecard badge
* Update README.md
2024-11-14 11:11:37 +02:00
c921d483a8
PG -156: replace query placeholders with actual arguments for prepared statements ( #481 )
...
* Denormalize prepared statement queries
Added support for extracting query arguments for prepared statements
when `pg_stat_monitor.pgsm_normalized_query` is off.
Previously pg_stat_monitor was unable to extract the arguments for
prepared statements, thus leaving queries with placeholders $1
.. $N instead of the actual arguments.
* Optmize query denormalization
Instead of copying original query text byte by byte, copy data between
query placeholders in chunks, example:
`INSERT INTO foo(a, b, c) VALUES('test', 100, 'test again)'`
Would result in normalized query:
`INSERT INTO foo(a, b, c) VALUES($1, $2, $3)`
The original patch would copy the parts between placeholders byte by
byte, e.g. `INSERT INTO foo(a, b, c) VALUES(`, instead we can copy this
whole block at once, 1 function call and maybe 1 buffer re-allocation
per call.
Also make use of `appendBinaryStringInfo` to avoid calculating string
length as we have this info already.
* Optmize query denormalization(2)
Avoid allocating an array of strings for extracting query argument
values, instead append the current parameter value directly in the
buffer used to store the denormalized query.
This avoids not only unnecessary memory allocations, but also copying
data between temporary memory and the buffer.
* Store denormalized query only under certain constraints
This commit introduces a little optimization along with a feature, it
stores the query in denormalized form only under the circumstances
below:
- The psgm_normalized_query GUC is disabled (off).
- The query is seem for the first time, or the query total
execution time exceeds the mean execution time calculated for
the previous queries.
Having the query which took most execution time along with it's
arguments could help users in further investigating performance issues.
* Fix regression tests
When query normalization is disabled utility queries like SELECT 10+20
are now stored as is, instead of SELECT $1+$2.
Also when functions or sub queries are created the arguments used
internally by the function or subqueries will be replaced by NULL instead
of $1..$N. The actual arguments will be displayed when the function or
subquery is actually invoked.
* Add query denormalization regression test for prepared statements
Ensures that the denormalization of prepared statements is working, also
ensure that a query which takes more time to execute replaces the
previous denormalized query.
* Updated pgsm_query_id regression tests
With the query dernomalization feature, having integer literals used in
sql like 1, or 2 could create some confusion on whether those are
placeholders or constant values, thus this commit updates the
pgsm_query_id regression test to use different integer literals to avoid
confusion.
* Improve query denormalization regression test
Add a new test case:
1. Execute a prepared statement with larger execution time first.
2. Execute the same prepared statement with cheap execution time.
3. Ensures that the denormalized heavy query is not replaced by the
cheaper.
* Format source using pgindent
* Fix top query regression tests on PG 12,13
On PG 12, 13, the internal return instruction in the following function:
```
CREATE OR REPLACE FUNCTION add(int, int) RETURNS INTEGER AS
$$
BEGIN
return (select $1 + $2);
END; $$ language plpgsql;
```
Is stored as SELECT (select expr1 + expr2)
On PG 14 onward it's stored just as SELECT (expr1 + expr2)
2024-11-01 19:28:16 -03:00
467394fb6e
Add timeouts to CI jobs ( #484 )
2024-08-26 12:00:58 -03:00
Zsolt Parragi
dependabot[bot]
Artem Gavrilov
Muhammad Aqeel
Andreas Karlsson
Artem Gavrilov
StepSecurity Bot
Diego Fronza